Changeset 08b7660

Timestamp:

Nov 29, 2013, 12:09:08 AM (12 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, stable, stage

Children:

a526ed2

Parents:

beb46fb

git-author:

Alex Dehnert <adehnert@…> (11/29/13 00:09:08)

git-committer:

Alex Dehnert <adehnert@…> (11/29/13 00:09:08)

Message:

Memberships: refactor issues.csv slightly

File:

• asadb/forms/views.py (modified) (3 diffs)

asadb/forms/views.py

@@ -527 +527 @@
     output.writerow(fields)
 
+    def output_issue(group, issue, num_confirms):
+        fields = [
+            group.id,
+            group.name,
+            issue,
+            num_confirms,
+            group.officer_email,
+        ]
+        if account_numbers: fields.append(group.main_account_id)
+        output.writerow(fields)
+
     q_present = Q(id__in=group_updates.values('group'))
     missing_groups = active_groups.filter(~q_present)
@@ -532 +543 @@
     for group in missing_groups:
         num_confirms = len(people_confirmations.filter(groups=group))
-        fields = [
-            group.id,
-            group.name,
-            'unsubmitted',
-            num_confirms,
-            group.officer_email,
-        ]
-        if account_numbers: fields.append(group.main_account_id)
-        output.writerow(fields)
+        output_issue(group, 'unsubmitted', num_confirms)
 
     for group_update in group_updates:
@@ -556 +559 @@
 
         for problem in problems:
-            fields = [
-                group.id,
-                group.name,
-                problem,
-                num_confirms,
-                group.officer_email,
-            ]
-            if account_numbers: fields.append(group.main_account_id)
-            output.writerow(fields)
-
+            output_issue(group, problem, num_confirms)
 
     return HttpResponse(buf.getvalue(), mimetype='text/csv', )