Changeset 2a587e4

Timestamp:

Feb 7, 2012, 12:09:58 AM (14 years ago)

Author:

ASA Group Database <asa-db@…>

Branches:

master, space-access, stable, stage

Children:

a86a924, bb48649

Parents:

ffdfde5

git-author:

Alex Dehnert <adehnert@…> (02/07/12 00:03:44)

git-committer:

ASA Group Database <asa-db@…> (02/07/12 00:09:58)

Message:

Misc. fixes for find_missing_transition.py

• Add @mit.edu as necessary
• Don't send messages to board members
• Comment out the mail sending (uncomment to actually send...)
• Minor editing of the template language

Location:

asadb

Files:

• groups/find_missing_transition.py (modified) (3 diffs, 1 prop)
• template/groups/letters/missing-transition.txt (modified) (2 diffs)

asadb/groups/find_missing_transition.py

@@ -41 +41 @@
     return fail, problems
 
+def canonicalize_email(email):
+    if '@' in email: return email
+    elif email == '': return ''
+    else: return email + "@mit.edu"
+
 def officers_lists(fd, ):
     reader = csv.DictReader(fd)
@@ -46 +51 @@
     for d in reader:
         pk = int(d['ASA_STUDENT_GROUP_KEY'])
-        lists[pk] = d['OFFICER_EMAIL']
+        lists[pk] = canonicalize_email(d['OFFICER_EMAIL'])
     return lists
 
@@ -70 +75 @@
                 from_email='asa-exec@mit.edu',
                 to=to,
-                bcc=['asa-admin@mit.edu' , 'asa-db-outgoing@mit.edu'],
+                bcc=['asa-db-outgoing@mit.edu'],
             )
             emails.append(email)
 
     connection = mail.get_connection()
-    connection.send_messages(emails)
+    #connection.send_messages(emails)
+    for email in emails: print email.subject
+    print len(emails)
 
 if __name__ == '__main__':

asadb/template/groups/letters/missing-transition.txt

@@ -3 +3 @@
    We believe that you have not yet fully updated your entry in the new ASA Group Database. As we have said previously (e.g., in an email to asa-official@mit.edu on 1/23/2012), the ASA is transitioning to a new database.  As part of this transition, groups are responsible for inputting most of their group's information to ensure that it is up-to-date.  MIT offices will be starting to use the new database now. It is critical to your group's ability to continue making financial transactions and reserving space that you list your signatories soon. Additionally, without updating basic information such as officer's email, the ASA will be unable to keep you updated on important news like midway, funding, and application deadlines.
 
-More information about accessing and using the new Database and which fields need to be updated is posted at: http://web.mit.edu/asa/database/
+More information about accessing and using the new Database and which fields need to be updated is posted at: http://web.mit.edu/asa/database/.
 
+Your group's page can be found at https://asa.mit.edu/groups/{{group.pk}}/.
 
 In particular, we believe that your group's entry has the following issues:
@@ -10 +11 @@
 {% endfor %}
 
-We appreciate you cooperation in fixing these quickly. If you have any questions, comments, or concerns, please contact asa-exec@mit.edu.
+We appreciate you cooperation in fixing these quickly. If you believe this message to be in error, please be sure to contact us at asa-exec@mit.edu.
+
+If you have questions, comments, concerns, or suggestions for improving the new database, please let us know.
 
 Thanks,