Changeset 2c9e652

Timestamp:

Sep 16, 2012, 7:05:16 PM (13 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

ac9b167

Parents:

32c5f16

git-author:

Alex Dehnert <adehnert@…> (09/16/12 19:05:16)

git-committer:

Alex Dehnert <adehnert@…> (09/16/12 19:05:16)

Message:

Add newly created groups to asa-official (ASA-#111)

This fixes a bug added when groups/diffs.py was original created
(b6c7a4422c99475fee21445f136583e19751d838) by actually calling new_group when
appropriate. It uses the design from when asa-official updating was originally
added (4098256caab3ba58f03a31e194d705e766458570). It is reasonably likely that
we want to add groups to asa-official not when they get created but rather when
the become active, but that's a later change.

File:

• asadb/groups/diffs.py (modified) (4 diffs)

asadb/groups/diffs.py

@@ -207 +207 @@
 
     def new_group(self, after, after_fields, ):
-        self.add.append(after_fields['officer_email'])
+        name = after_fields['name']
+        email = after_fields['officer_email']
+        self.add.append(email)
+        self.notes.append("%s: New group (email %s)" % (name, email, ))
 
 
@@ -268 +271 @@
         after_versions = all_versions.filter(revision__in=new_revs).select_related('revision__user')
         after = after_versions[0]
+        after_fields = after.field_dict
 
         if len(before_versions) > 0 or len(after_versions) > 1:
@@ -285 +289 @@
             #)
             before_fields = before.field_dict
-            after_fields = after.field_dict
             for callback in callbacks:
                 callback.handle_group(before, after, before_fields, after_fields)
@@ -295 +298 @@
             # normal new groups)
             stats['new_group'] += 1
+            callback.new_group(after, after_fields)
 
 def diff_signatories(since, now, callbacks):