Changeset 6559695 for asadb/groups

Timestamp:

Dec 23, 2012, 9:46:56 PM (13 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

161ce5f

Parents:

bb61160

git-author:

Alex Dehnert <adehnert@…> (12/23/12 21:46:56)

git-committer:

Alex Dehnert <adehnert@…> (12/23/12 21:46:56)

Message:

constitution-req.html is not a valid constitution

In groups/gather-constitutions.py and the related
​https://asa.mit.edu/groups/constitutions/, this stops treating constitutions
containing /asa/start/constitution-req.html as valid constitutions. This makes
it easier to see how many and which groups really have a constitution, and
which don't. Fixes ASA-#170.

File:

• asadb/groups/models.py (modified) (2 diffs)

asadb/groups/models.py

@@ -170 +170 @@
         success = None
         old_success = (self.failure_date is None)
-        if url:
+        if url and '/asa/start/constitution-req.html' not in url:
             # Fetch the file
             error_msg = None
@@ -236 +236 @@
                     self.record_success("updated in place", updated=True)
 
+        elif '/asa/start/constitution-req.html' in url:
+            self.record_failure("constitution-req used")
+            success = False
         else:
             self.record_failure("no url")