Changeset 80a8145

Timestamp:

Feb 26, 2012, 4:22:21 PM (14 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

014f227, 65c0a28

Parents:

4091199

git-author:

Alex Dehnert <adehnert@…> (02/26/12 16:18:33)

git-committer:

Alex Dehnert <adehnert@…> (02/26/12 16:22:21)

Message:

Fix new groups in groups/diffs.py (Trac: #67)

This is three related fixes.

The Trac issue is that it turns out Django doesn't like negative queryset
indexes, so do a .reverse() and then a positive index...

The second issue is that, even if the negative indexed worked, we wanted to
be updating before, not after --- we want to set the original we're diffing
against, not the current version, despite the fact that we're grabbing the
original from after_versions instead of before_versions.

Finally, the third issue is that the comment about the no-change case is
misleading --- even when a group is just recognized, it still will have
multiple versions. In particular, the startup form submission + the approval.
This adds a clarifying comment.

File:

• asadb/groups/diffs.py (modified) (2 diffs)

asadb/groups/diffs.py

@@ -224 +224 @@
                 # New group that's been edited since. Diff against the creation
                 # (since creation sent mail, but later changes haven't)
-                after = after_versions[-1]
+                before = after_versions.reverse()[0]
                 stats['change_new'] += 1
             stats['change_total'] += 1
@@ -238 +238 @@
         else:
             # New group that's only been edited once
+            # Note that "normal" new groups will have their startup form
+            # (which creates the Group object) and the approval (which makes
+            # more changes, so this is group startups + NGEs, not actually
+            # normal new groups)
             stats['new_group'] += 1