Changeset 8cf11c9

Timestamp:

Feb 6, 2012, 4:10:36 AM (14 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

ffdfde5

Parents:

1aaa525

git-author:

Alex Dehnert <adehnert@…> (02/06/12 04:10:36)

git-committer:

Alex Dehnert <adehnert@…> (02/06/12 04:10:36)

Message:

Only warn groups if they lack something we need

We don't actually require that groups have a financial or reservation
signatory, so don't email them if that's all they're missing.

File:

• asadb/groups/find_missing_transition.py (modified) (3 diffs)

asadb/groups/find_missing_transition.py

@@ -18 +18 @@
 def get_roles():
     roles = [
-        ['treasurer', 'No treasurer listed', ],
-        ['financial', 'No financial signatories listed. At minimum, this should generally be your president and treasurer.', ],
-        ['reservation', 'No reservation signatories listed. Members reserving space for the group should be reservation signatories.', ],
+        ['treasurer', True, 'No treasurer listed', ],
+        ['financial', False, 'No financial signatories listed. At minimum, this should generally be your president and treasurer.', ],
+        ['reservation', False, 'No reservation signatories listed. Members reserving space for the group should be reservation signatories.', ],
     ]
     for role in roles:
@@ -29 +29 @@
 def check_group(group, roles, ):
     problems = []
+    fail = False
     if group.officer_email or group.description:
         pass
     else:
         problems.append("No basic group information listed")
-    for role, msg in roles:
+        fail = True
+    for role, cause_fail, msg in roles:
         if len(group.officers(role=role)) == 0:
             problems.append(msg)
-    return problems
+            if cause_fail: fail = True
+    return fail, problems
 
 def officers_lists(fd, ):
@@ -52 +55 @@
     emails = []
     for group in groups.models.Group.active_groups.all():
-        problems = check_group(group, roles, )
-        if problems:
+        fail, problems = check_group(group, roles, )
+        if fail:
             to = [officers[group.pk]]
             if group.officer_email: