Changeset 9a30b56

Timestamp:

Mar 16, 2012, 5:46:59 AM (14 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

8254020

Parents:

74e9f09

git-author:

Alex Dehnert <adehnert@…> (03/16/12 05:46:08)

git-committer:

Alex Dehnert <adehnert@…> (03/16/12 05:46:59)

Message:

Fix off-by-one error in groups/diffs.py summaries

As a bonus, makes the code simpler... Though that's not totally a coincidence.

File:

• asadb/groups/diffs.py (modified) (2 diffs)

asadb/groups/diffs.py

@@ -59 +59 @@
         self.signatory_updates = []
         self.signatory_type_counts = {
-            'Added': {},
-            'Expired': {},
+            'Added': collections.defaultdict(lambda: 0),
+            'Expired': collections.defaultdict(lambda: 0),
         }
         self.since = since
@@ -85 +85 @@
                 change_type = "Expired"
             counter = self.signatory_type_counts[change_type]
-            if signatory.role.slug in counter:
-                counter[signatory.role.slug] += 1
-            else:
-                counter[signatory.role.slug] = 0
+            counter[signatory.role.slug] += 1
             if signatory.role.slug in self.interesting_signatories:
                 if signatory.group != prev_group: