Changeset 9ce8bc1

Timestamp:

Sep 8, 2012, 8:32:37 PM (13 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

5f07d50

Parents:

2e5dc1b

git-author:

Alex Dehnert <adehnert@…> (09/08/12 20:32:37)

git-committer:

Alex Dehnert <adehnert@…> (09/08/12 20:32:37)

Message:

Save error messages and narrow except clause

Apparently, we weren't bothering to actually *save* the GroupConstitution?
object at the right time consistently, which means that we were routinely
losing the error messages. This fixes that, and also ensures we only catch
IOErrors, since other things are likely the code's fault.

File:

• asadb/groups/models.py (modified) (3 diffs)

asadb/groups/models.py

@@ -145 +145 @@
             except IOError:
                 self.failure_date = now
+                self.status_msg = "retrieval failed"
+                self.failure_reason = self.status_msg
                 self.save()
                 success = False
-                self.status_msg = "retrieval failed"
-                self.failure_reason = self.status_msg
                 return (success, self.status_msg, old_success, )
             if tmp_path == url:
@@ -179 +179 @@
             self.status_msg = "no url"
             self.failure_reason = self.status_msg
+            self.save()
         return (success, self.status_msg, old_success, )
 
@@ -233 +234 @@
                 stream = urllib.urlopen(self.source_url)
                 return stream.getcode()
-            except:
+            except IOError:
                 return "IOError"
         else: