Changeset a8cd440

Timestamp:

Jan 23, 2012, 3:37:25 AM (14 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

96754f0

Parents:

777e9b2

git-author:

Alex Dehnert <adehnert@…> (01/23/12 03:37:25)

git-committer:

Alex Dehnert <adehnert@…> (01/23/12 03:37:25)

Message:

Data verification infrastructure (Trac: #22)

This includes:

• a script to remove data that we want people to verify (groups/purge_for_transition.py)
• code to make more fields required in the normal update interface
• explanatory message to help people with problematic constitutions
• adding an "Other" activity category so we can require that field

Location:

asadb

Files:

• groups/fixtures/initial_data.xml (modified) (1 diff)
• groups/purge_for_transition.py (added)
• groups/views.py (modified) (3 diffs)
• template/groups/group_change_main.html (modified) (1 diff)

asadb/groups/fixtures/initial_data.xml

@@ -43 +43 @@
         <field type="CharField" name="name">Technology</field>
     </object>
+    <object pk="15" model="groups.activitycategory">
+        <field type="CharField" name="name">Other</field>
+    </object>
 </django-objects>

asadb/groups/views.py

@@ -21 +21 @@
 from django.db import connection
 from django.db.models import Q
+from django.utils.safestring import mark_safe
 
 import form_utils.forms
@@ -110 +111 @@
             value = getattr(self.instance, field_name)
             StaticWidget.replace_widget(formfield, value)
+        for field in self.force_required:
+            self.fields[field].required = True
+        self.fields['constitution_url'].help_text = mark_safe("Please put your current constitutional URL, if you have one.<br>If your constitution is currently an AFS path, you can either use the corresponding web.mit.edu (e.g., http://web.mit.edu/locker/path/to/const.html) or stuff.mit.edu path, or just use http://asa.mit.edu/const/afs/your-afs-path.<br>If you don't currently know where your constitution is, put http://asa.mit.edu/const/missing/.<br>(In either of the http://asa.mit.edu/const/ cases, we'll get in touch with you later about putting something better in.)")
 
     exec_only_fields = [
@@ -119 +123 @@
         'recognition_date',
     ]
+    force_required = [
+        'activity_category', 'description',
+        'num_undergrads', 'num_grads', 'num_community', 'num_other',
+        'website_url', 'officer_email', 'group_email',
+        'constitution_url', 'athena_locker',
+    ]
+
 
     class Meta:

asadb/template/groups/group_change_main.html

@@ -6 +6 @@
 
 <h1>{{group.name}}: Change main information</h1>
+
+<p>We're using the transition from the old ASA Database to this new one as an opportunity to verify that old information is still accurate. Thus, we have intentionally limited the amount of information we copied from the old database. While filling this out, feel free to refer to the <a href='https://sisapp2.mit.edu/asa/student_group_detail.do?action=detail&amp;studentGroupId={{group.pk}}'>old database</a>. However, please verify that information is accurate as you copy it over. As always, if you have trouble, please <a href='mailto:asa-exec@mit.edu'>contact us</a>.</p>
 
 {% if msg %}