Changeset afc5348

Timestamp:

Feb 8, 2013, 4:44:17 AM (13 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

3cb9b1e

Parents:

8124413

git-author:

Alex Dehnert <adehnert@…> (02/08/13 04:44:17)

git-committer:

Alex Dehnert <adehnert@…> (02/08/13 04:44:17)

Message:

Import settings from django.conf (ASA-#126)

For some reason, importing the settings module directly is discouraged, and you
should instead use the settings object from django.conf (see
​https://docs.djangoproject.com/en/dev/topics/settings/#using-settings-in-python-code).

Location:

asadb

Files:

• forms/models.py (modified) (2 diffs)
• forms/views.py (modified) (1 diff)
• groups/diffs.py (modified) (2 diffs)
• groups/models.py (modified) (2 diffs)
• urls.py (modified) (2 diffs)

asadb/forms/models.py

@@ +1 @@
+from django.conf import settings
 from django.db import models
 
@@ -4 +5 @@
 import os, errno
 
-import settings
 import groups.models
 from util.misc import log_and_ignore_failures, mkdir_p

asadb/forms/views.py

@@ -2 +2 @@
 import groups.models
 import groups.views
-import settings
 import util.emails
 
+from django.conf import settings
 from django.contrib.auth.decorators import user_passes_test, login_required, permission_required
 from django.core.exceptions import PermissionDenied

asadb/groups/diffs.py

@@ -11 +11 @@
     os.environ['DJANGO_SETTINGS_MODULE'] = 'settings'
 
+from django.conf import settings
 from django.contrib.contenttypes.models import ContentType
 from django.core.mail import EmailMessage, mail_admins
@@ -21 +22 @@
 
 import groups.models
-import settings
 import util.emails
 import util.mailinglist

asadb/groups/models.py

@@ +1 @@
+from django.conf import settings
 from django.db import models
 from django.core.validators import RegexValidator
@@ -15 +16 @@
 import urllib
 import urllib2
-
-import settings
 
 import mit

asadb/urls.py

@@ +1 @@
+from django.conf import settings
 from django.conf.urls.defaults import *
 from django.contrib.auth.views import login, logout
@@ -6 +7 @@
 from django.contrib import admin
 admin.autodiscover()
-
-import settings
 
 import groups.urls