Changeset df88ee9

Timestamp:

May 31, 2012, 2:59:36 AM (14 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

b32adb6

Parents:

d768e47

git-author:

Alex Dehnert <adehnert@…> (05/31/12 02:37:46)

git-committer:

Alex Dehnert <adehnert@…> (05/31/12 02:59:36)

Message:

Use transaction.commit_on_success for imports

Fixed the following scripts:

• forms/update_validations.py (15s->1s for 70ish validations)
• space/import_into_db.py (67s->1s for 75 spaces and 100 assignments)
• util/sync_moira_authz.py (65s->4s for importing ~50 new people)

util/update_old_previews.py was skipped:

• it's dead code, I believe --- I think previews are unused
• preview updating is slow, IIRC; it's dubious we'd get noticeably better runtime on the script, and there may even be utility to the progress updates not doing this transactionally supplies

This closes ASA Trac #59.

Location:

asadb

Files:

• forms/update_validations.py (modified) (1 diff)
• space/import_into_db.py (modified) (2 diffs)
• util/sync_moira_authz.py (modified) (2 diffs)

asadb/forms/update_validations.py

@@ -12 +12 @@
     os.environ['DJANGO_SETTINGS_MODULE'] = 'settings'
 
+from django.db import transaction
+
 import forms.models
 import groups.models
 
 
+@transaction.commit_on_success
 def revalidate_confirmations():
     confirmations = forms.models.PersonMembershipUpdate.objects.filter(deleted__isnull=True, valid=forms.models.VALID_UNSET)

asadb/space/import_into_db.py

@@ -10 +10 @@
     sys.path.append(django_dir)
     os.environ['DJANGO_SETTINGS_MODULE'] = 'settings'
+
+from django.db import transaction
 
 import groups.models
@@ -40 +42 @@
     assignment.save()
 
+@transaction.commit_on_success
 def process_spaces(reader):
     space.models.SpaceAssignment.objects.filter(end=max_date).update(end=today)

asadb/util/sync_moira_authz.py

@@ -16 +16 @@
 
 import django.contrib.auth.models
+from django.db import transaction
 
 import mit
@@ -77 +78 @@
         return self.sync_helper(sys_name, dj_members, adder, remover, )
 
+    @transaction.commit_on_success
     def sync_many(con, what, force_print=False, ):
         changed = False