Changes between Initial Version and Version 1 of Ticket #94
- Timestamp:
- Apr 10, 2012, 4:34:16 AM (14 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #94 – Description
initial v1 1 manage_officers is no longer "a somewhat intimidating 100+ line long function with up to eight layers of indentation in some places" . Instead, it's a 250+ line morass of six functions with terrible APIs and uncertain purposes, with up to five layers of indent. Which... is a different problem. Sort of. It still wants to be cleaned up, until the various helper functions actually have a clear purpose in life, instead of being "lets yoink a chunk of 50 lines and slap the minimal function header that lets it run on".1 manage_officers is no longer "a somewhat intimidating 100+ line long function with up to eight layers of indentation in some places" (ASA #87). Instead, it's a 250+ line morass of six functions with terrible APIs and uncertain purposes, with up to five layers of indent. Which... is a different problem. Sort of. It still wants to be cleaned up, until the various helper functions actually have a clear purpose in life, instead of being "lets yoink a chunk of 50 lines and slap the minimal function header that lets it run on". 2 2 3 3 Some likely-useful steps:
