Changeset 492251a for asadb/space/diffs.py

Timestamp:

Jan 30, 2013, 1:36:34 AM (13 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

59506d6

Parents:

1484698

git-author:

Alex Dehnert <adehnert@…> (01/30/13 01:36:34)

git-committer:

Alex Dehnert <adehnert@…> (01/30/13 01:36:34)

Message:

Comment space/diffs.py's locker code a bit better

File:

• asadb/space/diffs.py (modified) (2 diffs)

asadb/space/diffs.py

@@ -177 +177 @@
 
 def safe_add_change_real(change_by_name, change):
+    """Add a new change to our dict of pending changes.
+
+    If a different change has already been added for this person (eg, "Remove"
+    instead of "Keep", or with a different list of groups), error.  This should
+    always succeed; if it doesn't, the code is buggy. We worry about this
+    because we want to be really sure that the email that goes to just CAC is
+    compatible with the emails that go to each groups. Since we iterate over
+    the changes once per group, we want to be sure that for each group
+    iteration we're building compatible information.
+    """
+
     name = change.name
     if name in change_by_name:
@@ -200 +211 @@
         print "ID=%s (%s):\n\t%s\t(%s)\n\t%s\t(%s)\n" % (mit_id, unchanged, old_by_names, old_by_group, new_by_names, new_by_group, ),
         for group_pk in joint_keys(old_by_group, new_by_group):
+            # TODO: Do we need to do an iteration for each group? This seems
+            # slightly questionable. Can we just loop over all known names?
+
             old_names = old_by_group[group_pk]
             new_names = new_by_group[group_pk]