Changeset 7b00af8 for asadb/groups/views.py

Timestamp:

Mar 14, 2013, 5:04:17 AM (13 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

9b22b0f

Parents:

58fe19c

git-author:

Alex Dehnert <adehnert@…> (03/14/13 04:55:16)

git-committer:

Alex Dehnert <adehnert@…> (03/14/13 05:04:17)

Message:

Allow search by account number, officer list

Both had privacy concerns, but I think they're fine:

Account numbers (ASA-#122) can already be looked up, entirely unauthenticated,
with the account lookup tool (​https://asa.mit.edu/groups/account_lookup/).
Exposing a search for exact account numbers on the search page too seems
acceptable in this light.

Officer lists (ASA-#123) are mostly public --- they're available to anybody
with certs, they're on most groups' websites, and I believe we'd display them
obfuscated to the whole world if we had obfuscation code. The possibility of
somebody scraping the search page with progressively more refined search terms
to get this data seems acceptable.

File:

• asadb/groups/views.py (modified) (3 diffs)

asadb/groups/views.py

@@ -31 +31 @@
 
 from util.db_form_utils import StaticWidget
+import util.db_filters
 from util.emails import email_from_template
 
@@ -900 +901 @@
     name = django_filters.CharFilter(lookup_type='icontains', label="Name contains")
     abbreviation = django_filters.CharFilter(lookup_type='iexact', label="Abbreviation is")
+    officer_email = django_filters.CharFilter(lookup_type='icontains', label="Officers' list contains")
+
+    account_filter = util.db_filters.MultiNumberFilter(
+        lookup_type='exact', label="Account number",
+        names=('main_account_id', 'funding_account_id', ),
+    )
 
     class Meta:
@@ -906 +913 @@
             'name',
             'abbreviation',
+            'officer_email',
             'activity_category',
             'group_class',
             'group_status',
             'group_funding',
+            'account_filter',
         ]