Changeset 7dde669

Timestamp:

Nov 30, 2013, 9:51:49 PM (12 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, stable, stage

Children:

aed3e6d

Parents:

00ec3e4

git-author:

Alex Dehnert <adehnert@…> (11/30/13 16:36:14)

git-committer:

Alex Dehnert <adehnert@…> (11/30/13 21:51:49)

Message:

Add pre-group-approval warnings

This fixes (enough, at least for now) several issues by adding warnings
to the approval page when certain constraints are violated:

• ASA-#216: New group "ERROR:" emails should get suppressed earlier
• ASA-#234: max locker name length
• ASA-#246: Add reminders of common issues to the new group confirmation page

Location:

asadb

Files:

• groups/views.py (modified) (3 diffs)
• template/groups/create/startup_review.html (modified) (1 diff)

asadb/groups/views.py

@@ -696 +696 @@
             from_email='asa-admin@mit.edu',
         )
-        # XXX: Handle this better
-        if officer_domain != 'mit.edu' or (create_group_list and group_domain != 'mit.edu'):
-            accounts_mail.to = ['asa-groups@mit.edu']
-            accounts_mail.cc = ['asa-db@mit.edu']
-            accounts_mail.subject = "ERROR: " + accounts_mail.subject
-            accounts_mail.body = "Bad domain on officer or group list\n\n" + accounts_mail.body
 
     else:
@@ -828 +822 @@
     return render_to_response('groups/create/startup.html', context, context_instance=RequestContext(request), )
 
+def review_group_check_warnings(group_startup, group, ):
+    warnings = []
+
+    if group.name.startswith("MIT "):
+        warnings.append('Group name starts with "MIT". Generally, we prefer "Foo, MIT" instead.')
+    if "mit" in group.athena_locker.lower():
+        warnings.append('Athena locker name contains "mit", which may be redundant with paths like "http://web.mit.edu/mitfoo" or "/mit/foo/".')
+
+    if group_startup.president_kerberos == group_startup.treasurer_kerberos:
+        warnings.append('President matches Treasurer.')
+    if "%s@mit.edu" % (group_startup.president_kerberos, ) in (group.officer_email, group.group_email):
+        warnings.append('President email matches officer and/or group email.')
+    if group.officer_email == group.group_email:
+        warnings.append('Officer email matches group email.')
+
+    if '@mit.edu' not in group.officer_email or '@mit.edu' not in group.group_email:
+        warnings.append('Officer and/or group email are non-MIT. Ensure that they are not requesting the addresses be created, and consider suggesting they use an MIT list instead.')
+
+    if '.' in group.athena_locker:
+        warnings.append('Athena locker contains a ".". This is not compatible with scripts.mit.edu\'s wildcard certificate, and may cause other problems.')
+    if '_' in group.athena_locker:
+        warnings.append('Athena locker contains a "_". If this locker name gets used in a URL (for example, locker.scripts.mit.edu), it will technically violate the hostname specification and may not work in some clients.')
+    if len(group.athena_locker) > 12:
+        warnings.append('Athena locker is more than twelve characters long. In general, twelve characters is the longest Athena locker an ASA-recognized group can get.')
+
+    return warnings
+
 @permission_required('groups.recognize_group')
 def recognize_normal_group(request, pk, ):
@@ -843 +864 @@
     if group_startup.stage != groups.models.GROUP_STARTUP_STAGE_SUBMITTED:
         return render_to_response('groups/create/err.not-applying.html', context, context_instance=RequestContext(request), )
+
+    context['warnings'] = review_group_check_warnings(group_startup, group)
 
     context['msg'] = ""

asadb/template/groups/create/startup_review.html

@@ -51 +51 @@
 {% endif %}
 
+{% if warnings %}
+<div class='messagebox warnbox'>
+<h3>Potential issues</h3>
+
+<p>The following potential issues were identified with this group's startup application:</p>
+
+<ul>
+{% for warning in warnings %}
+    <li>{{warning}}</li>
+{%endfor%}
+</ul>
+
+<p>Please look over these issues. Usually, you should <strong>reach out to the group</strong> and ask them to fix (or consider fixing) each issue before you approve the group. In some cases, it may be appropriate to ignore an issue. (For example, "MIT" is a central part of some group's acronyms (like "HTGAMIT"). In these cases, confirming with the group may not be necessary.)</p>
+</div>
+{%endif%}
+
 {% if disp_form %}
 <form enctype="multipart/form-data" method="post" action="">
 {% csrf_token %}
+{% if warnings %}
+<input type='submit' name='approve' value='Approve DESPITE WARNINGS' />
+{% else %}
 <input type='submit' name='approve' value='Approve' />
+{% endif %}
 <input type='submit' name='reject' value='Reject' />
 </form>