Changeset 7dde669 for asadb/template/groups/create/startup_review.html

Timestamp:

Nov 30, 2013, 9:51:49 PM (13 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, stable, stage

Children:

aed3e6d

Parents:

00ec3e4

git-author:

Alex Dehnert <adehnert@…> (11/30/13 16:36:14)

git-committer:

Alex Dehnert <adehnert@…> (11/30/13 21:51:49)

Message:

Add pre-group-approval warnings

This fixes (enough, at least for now) several issues by adding warnings
to the approval page when certain constraints are violated:

• ASA-#216: New group "ERROR:" emails should get suppressed earlier
• ASA-#234: max locker name length
• ASA-#246: Add reminders of common issues to the new group confirmation page

File:

• asadb/template/groups/create/startup_review.html (modified) (1 diff)

asadb/template/groups/create/startup_review.html

@@ -51 +51 @@
 {% endif %}
 
+{% if warnings %}
+<div class='messagebox warnbox'>
+<h3>Potential issues</h3>
+
+<p>The following potential issues were identified with this group's startup application:</p>
+
+<ul>
+{% for warning in warnings %}
+    <li>{{warning}}</li>
+{%endfor%}
+</ul>
+
+<p>Please look over these issues. Usually, you should <strong>reach out to the group</strong> and ask them to fix (or consider fixing) each issue before you approve the group. In some cases, it may be appropriate to ignore an issue. (For example, "MIT" is a central part of some group's acronyms (like "HTGAMIT"). In these cases, confirming with the group may not be necessary.)</p>
+</div>
+{%endif%}
+
 {% if disp_form %}
 <form enctype="multipart/form-data" method="post" action="">
 {% csrf_token %}
+{% if warnings %}
+<input type='submit' name='approve' value='Approve DESPITE WARNINGS' />
+{% else %}
 <input type='submit' name='approve' value='Approve' />
+{% endif %}
 <input type='submit' name='reject' value='Reject' />
 </form>