Changeset aa6a940 for asadb/groups/views.py

Timestamp:

Aug 13, 2011, 9:53:10 PM (14 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage, test-hooks

Children:

0bd161f

Parents:

9bf5237

git-author:

Alex Dehnert <adehnert@…> (08/13/11 21:53:10)

git-committer:

Alex Dehnert <adehnert@…> (08/13/11 21:53:10)

Message:

Fix updater information

Systems updating entries should call set_updater with the updater (as a string
or request.user object) in order to ensure that the updater is correct.
Otherwise, it will be unset on instance.save(). Regardless, the update_time
will be updated.

This mechanism is independent of django-reversion's history functionality,
which also stores the updater.

Note, in particular, that the admin does not currently use this interface
to store the updater, but does store it in django-reversion's system (along
with the rest of the history). Porting the "view group" page over may be
desirable.

File:

• asadb/groups/views.py (modified) (3 diffs)

asadb/groups/views.py

@@ -78 +78 @@
     ]
     nobody_fields = [
-        'recognition_date', 'updater', 'update_date',
+        'recognition_date',
     ]
 
@@ -105 +105 @@
             ('more-info', {
                 'legend': 'Additional Information',
-                'fields': ['constitution_url', 'advisor_name', 'athena_locker', 'updater', 'update_date', ],
+                'fields': ['constitution_url', 'advisor_name', 'athena_locker', ],
             }),
         ]
@@ -131 +131 @@
 
         if form.is_valid(): # All validation rules pass
-            request_obj = form.save()
+            request_obj = form.save(commit=False)
+            request_obj.set_updater(request.user)
+            request_obj.save()
+            form.save_m2m()
 
             # Send email