Changeset bfc0d08

Timestamp:

Feb 11, 2014, 1:59:21 AM (12 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, stable, stage

Children:

4217b13

Parents:

3b39edc

git-author:

Alex Dehnert <adehnert@…> (02/11/14 01:56:31)

git-committer:

Alex Dehnert <adehnert@…> (02/11/14 01:59:21)

Message:

People lookup: handle round numbers (ASA-#253)

It turns out that failure to split on commas isn't actually the cause of
ASA-#253 (though it is certainly a usability issue); instead, if we have 100*n
Athena usernames (most likely, zero), we end up with an empty "chunk" of
usernames to send to the LDAP server. That results in a filter like "(|)",
which errors. This changes the code to suppress empty chunks.

File:

• asadb/forms/models.py (modified) (1 diff)

asadb/forms/models.py

@@ -234 +234 @@
             username_chunks.append(usernames[start:end])
             start = end
-        username_chunks.append(usernames[end:])
-        print username_chunks
+        extra = usernames[end:]
+        if extra:
+            username_chunks.append(extra)
 
         results = []