People lookup: handling commas better

[adehnert]

Entering "adehnert@…, adehnert@…" into the People Lookup form 500's and gives:

PROTOCOL_ERROR: {'info': 'Bad search filter', 'desc': 'Protocol error'}

in the email logs. It should probably changed first to fail to return anything, because the filter has proper escaping; and then to actually split on commas (and document the format of the list better) and return useful results.

[adehnert]

Fixed in:

commit 86986f5f81a33d784c523e305efc9cab7fb3d8ea
Author: Alex Dehnert <adehnert@mit.edu>
Date:   Tue Feb 11 01:54:59 2014 -0500

    People lookup: Handle more name formats (ASA-#253)
    
    - Split names on commas as well as newlines
    - Parse mailman list info pages -- convert "user at domain" to "user@domain"
      and ignore parentheses around addresses

commit 4217b13bd4ee379077bc9202b9cfb399b5c8794d
Author: Alex Dehnert <adehnert@mit.edu>
Date:   Tue Feb 11 01:31:53 2014 -0500

    People lookup: specify intended format (ASA-#253)

commit bfc0d0895e4b34fcd045d457cdce69a5ed748257
Author: Alex Dehnert <adehnert@mit.edu>
Date:   Tue Feb 11 01:56:31 2014 -0500

    People lookup: handle round numbers (ASA-#253)
    
    It turns out that failure to split on commas isn't actually the cause of
    ASA-#253 (though it is certainly a usability issue); instead, if we have 100*n
    Athena usernames (most likely, zero), we end up with an empty "chunk" of
    usernames to send to the LDAP server. That results in a filter like "(|)",
    which errors. This changes the code to suppress empty chunks.