Changeset c409ae1 for asadb/groups/views.py

Timestamp:

Mar 31, 2012, 5:59:05 PM (14 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, space-access, stable, stage

Children:

4b1f99b

Parents:

3534e89

git-author:

Alex Dehnert <adehnert@…> (03/31/12 17:59:05)

git-committer:

Alex Dehnert <adehnert@…> (03/31/12 17:59:05)

Message:

Don't do any prefetching if we don't need to

select_related() selects *everything*, so we can't just blithely run
select_related(*list(prefetch_fields)) without checking prefetch_fields
is non-empty.

File:

• asadb/groups/views.py (modified) (1 diff)

asadb/groups/views.py

@@ -840 +840 @@
         # Prefetch foreign keys
         prefetch_fields = groups.models.Group.reporting_prefetch()
-        prefetch_fields.intersection_update(basic_fields)
-        qs = qs.select_related(*list(prefetch_fields))
+        prefetch_fields = prefetch_fields.intersection(basic_fields)
+        if prefetch_fields:
+            qs = qs.select_related(*list(prefetch_fields))
         for group in qs:
             group_data = [getattr(group, field) for field in basic_fields]