Opened 14 years ago

Closed 13 years ago

#57 closed enhancement (fixed)

Treat 404ing or 500ing constitutions as an error

Reported by: adehnert Owned by:
Priority: normal Milestone: Sometime
Component: Core Version:
Keywords: Cc:
Size: large

Description

At the moment, due to the way I'm using urllib, constitution URLs that 404 or 500 are not treated as an error --- they just result constitutions that look an awful lot like an error page... This should be fixed.

Change History (3)

comment:1 Changed 14 years ago by adehnert

See also #50.

comment:2 Changed 14 years ago by adehnert

Geoff thinks we should use urllib2 instead of urllib.

comment:3 Changed 13 years ago by adehnert

  • Resolution set to fixed
  • Size set to large
  • Status changed from new to closed

Fixed this (partially by switching to urllib2):

commit c632b1c89ebf0698df3470e2a544ce82ab0077a3
Author: Alex Dehnert <adehnert@mit.edu>
Date:   Sun Sep 9 06:34:45 2012 -0400

    Treat 4XX response codes as constitution failures
    
    Fixes ASA-#57. This changes GroupConstitution.update() to use urllib2. It also
    improves the error handling to detect more errors (such as 404 response codes)
    and store more information about the various errors.
Note: See TracTickets for help on using tickets.