Opened 14 years ago

Closed 14 years ago

#87 closed enhancement (fixed)

Refactor manage_officers

Reported by: adehnert Owned by:
Priority: minor Milestone: Sometime
Component: People Version:
Keywords: Cc:
Size: medium

Description

manage_officers is a somewhat intimidating 100+ line long function with up to eight layers of indentation in some places. It (and some of the other functions in groups/views.py) could stand to be refactored. Even if the total line count goes up, hopefully it can become something a little easier to read.

Change History (1)

comment:1 Changed 14 years ago by adehnert

  • Resolution set to fixed
  • Status changed from new to closed

Fixed:

commit 59a438af4fd8ce22a61647e5ddeebdc0e19440c6
Author: Alex Dehnert <adehnert@mit.edu>
Date:   Mon Apr 9 13:22:20 2012 -0400

    Enhance readability of manage_officers view
    
    Try to break it up a bit more so it's a *little* bit easier to read. Also,
    hopefully, it'll be a bit easier to extend when fixing ASA Trac #90 et al.
    
    Fixes ASA Trac #87.
Note: See TracTickets for help on using tickets.