Changeset 0e2426b for asadb/forms/views.py

Timestamp:

Nov 29, 2013, 1:56:00 AM (12 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, stable, stage

Children:

429e162

Parents:

8a6faa1

git-author:

Alex Dehnert <adehnert@…> (11/29/13 01:56:00)

git-committer:

Alex Dehnert <adehnert@…> (11/29/13 01:56:00)

Message:

Save some unnecessary queries with select_related

Computing how many people have confirmed still requires O(n) queries, but at
least this gets rid of a few of the things that required O(n) queries.

File:

• asadb/forms/views.py (modified) (2 diffs)

asadb/forms/views.py

@@ -506 +506 @@
 
     check_groups = groups.models.Group.objects.filter(group_status__slug__in=('active', 'suspended', ))
-    check_groups = check_groups.select_related('group_status__slug')
+    check_groups = check_groups.select_related('group_status')
     group_updates = forms.models.GroupMembershipUpdate.objects.filter(cycle__slug=slug, )
+    group_updates = group_updates.select_related('group', 'group__group_status')
     people_confirmations = forms.models.PersonMembershipUpdate.objects.filter(
         deleted__isnull=True,
@@ -536 +537 @@
     #print len(list(group_updates))
     for group in missing_groups:
-        num_confirms = len(people_confirmations.filter(groups=group))
-        output_issue(group, 'unsubmitted', num_confirms)
+        #num_confirms = len(people_confirmations.filter(groups=group))
+        output_issue(group, 'unsubmitted', '')
 
     for group_update in group_updates: