Changeset 429e162 for asadb/forms/views.py

Timestamp:

Nov 29, 2013, 2:04:54 AM (12 years ago)

Author:

Alex Dehnert <adehnert@…>

Branches:

master, stable, stage

Children:

e4a35ff

Parents:

0e2426b

git-author:

Alex Dehnert <adehnert@…> (11/29/13 02:04:54)

git-committer:

Alex Dehnert <adehnert@…> (11/29/13 02:04:54)

Message:

Do my counting in the DB...

Really, I'd like to use something like annotate to make this one query, but
that doesn't seem to be reasonably possible (yet). Some options:

• I could use extra() (​https://docs.djangoproject.com/en/dev/ref/models/querysets/#extra), but that requires hand-writing SQL.
• It looks like a Prefetch object might work (​https://docs.djangoproject.com/en/dev/ref/models/queries/#django.db.models.Prefetch), but that's not available until Django 1.7. (Scripts is Django 1.4 right now; I predict Django 1.7 will release in late 2014 and reach scripts in Summer 2015.)
• Something with values() and/or select_related() might work (​http://stackoverflow.com/questions/19642627/subquery-in-select-django/19645545), but it looks like it would be a huge pain.
• F() expressions (​https://docs.djangoproject.com/en/dev/ref/models/queries/#f-expressions) growing some sort of generic subquery support feels plausible, but at the moment it looks like you can only pass in a string to identify a field, not a queryset.

File:

• asadb/forms/views.py (modified) (1 diff)

asadb/forms/views.py

@@ -542 +542 @@
     for group_update in group_updates:
         group = group_update.group
-        num_confirms = len(people_confirmations.filter(groups=group))
+        num_confirms = people_confirmations.filter(groups=group).count()
         problems = []